Skip to content

Commit

Permalink
[GCP DWS] Fix None issue when no provision timeout is provided (#3835)
Browse files Browse the repository at this point in the history
* Fix None issue when no provision timeout is provided

* raies instead of print

* Change to check provision_timeout is none
  • Loading branch information
Michaelvll authored Aug 16, 2024
1 parent df2a9b4 commit 69838f5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions sky/provision/gcp/mig_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,3 +207,4 @@ def wait_for_managed_group_to_be_stable(project_id: str, zone: str,
except subprocess.CalledProcessError as e:
stderr = e.stderr.decode('ascii')
logger.info(stderr)
raise
2 changes: 2 additions & 0 deletions sky/templates/gcp-ray.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ available_node_types:
{%- if gcp_use_managed_instance_group %}
managed-instance-group:
run_duration: {{ run_duration }}
{%- if provision_timeout is defined and provision_timeout is not none %}
provision_timeout: {{ provision_timeout }}
{%- endif %}
{%- endif %}
{%- if specific_reservations %}
reservationAffinity:
Expand Down

0 comments on commit 69838f5

Please # to comment.