Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[GCP DWS] Fix None issue when no provision timeout is provided #3835

Merged
merged 3 commits into from
Aug 16, 2024
Merged

[GCP DWS] Fix None issue when no provision timeout is provided #3835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b06620
Fix None issue when no provision timeout is provided
Michaelvll Aug 16, 2024
7e034f3
raies instead of print
Michaelvll Aug 16, 2024
b205166
Change to check provision_timeout is none
Michaelvll Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sky/provision/gcp/mig_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,3 +207,4 @@ def wait_for_managed_group_to_be_stable(project_id: str, zone: str,
except subprocess.CalledProcessError as e:
stderr = e.stderr.decode('ascii')
logger.info(stderr)
raise
2 changes: 2 additions & 0 deletions sky/templates/gcp-ray.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ available_node_types:
{%- if gcp_use_managed_instance_group %}
managed-instance-group:
run_duration: {{ run_duration }}
{%- if provision_timeout is defined and provision_timeout is not none %}
provision_timeout: {{ provision_timeout }}
{%- endif %}
{%- endif %}
{%- if specific_reservations %}
reservationAffinity:
Expand Down
Loading