Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[AWS] Support capacity block reservation #3853

Merged
merged 14 commits into from
Aug 22, 2024
Merged

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Aug 21, 2024

Blocked by #3852.

This PR adds support for capacity block reservations.

We are not able to test it at the moment due to the lack of quota for creating a capacity block.

Thanks a lot to @jasonkrone for the awesome instruction PR: https://github.com/skypilot-org/skypilot/pull/3818/files

Also, thanks Sherjil for helping us test this PR on real capacity block.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • A user tested it with their capacity block on f693555, and it seems working.
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Allow prioritize reservations

format

Allow open capacity reservations

Add check reserved resources

format

Remove specific reservations
author Zhanghao Wu <zhanghao.wu@outlook.com> 1724175607 +0000
committer Zhanghao Wu <zhanghao.wu@outlook.com> 1724210666 +0000

wip

Allow prioritize reservations

format

Add check reserved resources

format
@Michaelvll Michaelvll requested a review from cblmemo August 21, 2024 05:48
@Michaelvll
Copy link
Collaborator Author

@cblmemo This is ready for a review.

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature @Michaelvll ! LGTM

@Michaelvll Michaelvll added this pull request to the merge queue Aug 22, 2024
Merged via the queue into master with commit 8a0b1a1 Aug 22, 2024
20 checks passed
@Michaelvll Michaelvll deleted the support-capacity-block branch August 22, 2024 18:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants