Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: target the targeted user for meme #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OfficialSirH
Copy link
Contributor

The meme command would have the target option for targeting users but it would only ping the user and never actually utilized that targeted user for the meme as the memes specifically targeted only the author, which doesn't make much sense for single-character memes that should be targeting the targeted user rather than the author whilst memes with 2 characters (of which none exist in the json and db as there's only 3 memes of which are all single-character memes) would make more sense to have the author being the main character and the targeted user being the secondary character.

  • note: one change that can't be done here but would be necessary as well would be to swap the data between the author and target fields for all the memes in the db.

@favna
Copy link
Member

favna commented Mar 19, 2024

note: one change that can't be done here but would be necessary as well would be to swap the data between the author and target fields for all the memes in the db.

No meme info is stored in the db

@OfficialSirH
Copy link
Contributor Author

No meme info is stored in the db

oh, my bad, I forgot to mention the memes API when referring to the db. 😅

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants