-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bug: 3 inline then 1 out of line formats differently than Discord #509
Comments
Weird, doing that still has it wide, but I did remove like you said and it was fine: After doing: - <DiscordEmbedField fieldTitle="📻 Listen" inline={true} inlineIndex={1}>
+ <DiscordEmbedField fieldTitle="📻 Listen"> I get It looks like an inline-index still lingers? There is no If I explicitly set - <DiscordEmbedField fieldTitle="📻 Listen" inline={true} inlineIndex={1}>
+ <DiscordEmbedField fieldTitle="📻 Listen" inlineIndex={undefined}> Then it works fine with no editing. So it seems the bug is coming from it adding 1 for some reason? |
Fixes #509 Fix the issue with the bottom field not spanning across three inline fields in the embed. * Update `packages/core/src/components/discord-embed-field/DiscordEmbedField.ts` to set the `inline-index` attribute only when `inline` is true. * Add a check in `packages/core/src/components/discord-embed-field/DiscordEmbedField.ts` to ensure `inline-index` is not set when `inline` is false. * Update the grid column span logic in `packages/core/src/components/discord-embed-fields/DiscordEmbedFields.ts` to correctly span the bottom field across all three columns when `inline` is not set. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/skyra-project/discord-components/issues/509?shareId=XXXX-XXXX-XXXX-XXXX).
Fixes #509 Fix the issue with the bottom field not spanning across three inline fields in the embed. * Update `packages/core/src/components/discord-embed-field/DiscordEmbedField.ts` to set the `inline-index` attribute only when `inline` is true. * Add a check in `packages/core/src/components/discord-embed-field/DiscordEmbedField.ts` to ensure `inline-index` is not set when `inline` is false. * Update the grid column span logic in `packages/core/src/components/discord-embed-fields/DiscordEmbedFields.ts` to correctly span the bottom field across all three columns when `inline` is not set. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/skyra-project/discord-components/issues/509?shareId=XXXX-XXXX-XXXX-XXXX).
Bizarre that it was setting it to 1, sure that is the default but that shouldn't apply unless |
* fix: inline field bug in Discord embed Fixes #509 Fix the issue with the bottom field not spanning across three inline fields in the embed.
Released in alpha 37 |
Is there an existing issue for this?
Description of the bug
I seem to ran into a problem with inline rendering, at least on React.
Here's the code for what I have, for reference. https://github.com/Chew/ChewHelp/blob/master/src/components/mlb/PlanGameCommand.tsx
It renders mostly fine, see my docs.
But, it should look like this:
The bottom should span across the three, but only goes up to the first one and stops, causing some rendering issues.
It's very possible I broke something, I followed every guide I could to a tee!
Steps To Reproduce
Expected behavior
I expected it to look like Discord, with the bottom field spanning all three.
Screenshots
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: