add: New arguments in the modal #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I definitely don't know why it gave an error before but maybe it was because I forgot to use "yarn lint" |
favna
requested changes
Aug 20, 2024
packages/core/src/components/discord-input-text/DiscordInputText.ts
Outdated
Show resolved
Hide resolved
|
Again, I definitely don't know why it gave an error before but maybe it was because I forgot to use "yarn lint" |
eumarciel404
commented
Aug 22, 2024
I was using the modals recently and I saw that there is one more message in a specific circumstance so I added that message, added new attributes to the class and repositioned the messages
Added a function to show the new "error" message
Here I added a function to make the "error" message of minimal characters "disappear" when closing the modal
I added an extra check on line 410, because as it was, it didn't show the minimum character message in short inputs, and I added a listener so that every time the modal is closed the minimum characters "error" disappears
- ensured validation cases work properly - ensure warnings properly get removed on closing
Adding minimum size verification, now only the minimum size message will appear in some cases the same as discord - When the field is required - When the value of the field is greater than 1 character and less than the minimum I added this check because before there was none and it always showed the message even if the inputtext was not necessary
Here i changed the atribute "hasWarning" to public for use in modal class (more for polishing) e adicionei mais algumas verificações especificas na contagem de caracters (again to polishing)
Here a changed the variable "defaultValue" for the "value" in line 352 and 353,in view of that the variable "value" recieves the variable "defaultValue"
favna
force-pushed
the
New-arguments-in-the-modal
branch
from
2a9a56c to
fbc037c
Compare
favna
approved these changes
Aug 24, 2024
favna
added a commit
that referenced
this pull request
Aug 24, 2024
* feat: adding new "error" message I was using the modals recently and I saw that there is one more message in a specific circumstance so I added that message, added new attributes to the class and repositioned the messages * add: function to show new "error" message Added a function to show the new "error" message * Update DiscordModal.ts * Update DiscordInputText.ts * fix: Change "minimum characters" message display Here I added a function to make the "error" message of minimal characters "disappear" when closing the modal * fix: Fixing some verification errors and adding a listener I added an extra check on line 410, because as it was, it didn't show the minimum character message in short inputs, and I added a listener so that every time the modal is closed the minimum characters "error" disappears * fix: some small fixes for validations * fix: change ! To ? * fix: various fixes - ensured validation cases work properly - ensure warnings properly get removed on closing * Fix: Solving Value Not Returning to Default * fix: remove unnecessary type * fix: Closing unclosed tag and fixing indentation * fix: remove accidental console.log * Fix: Fixed issue of looping the default value * Update DiscordInputText.ts * add: Adding an example of a default value in the modal * Fix: Adding More Verification Adding minimum size verification, now only the minimum size message will appear in some cases the same as discord - When the field is required - When the value of the field is greater than 1 character and less than the minimum I added this check because before there was none and it always showed the message even if the inputtext was not necessary * fix: Changing a atributte of class and add news arguments Here i changed the atribute "hasWarning" to public for use in modal class (more for polishing) e adicionei mais algumas verificações especificas na contagem de caracters (again to polishing) * fix: changing variable in verification Here a changed the variable "defaultValue" for the "value" in line 352 and 353,in view of that the variable "value" recieves the variable "defaultValue" * fix: ensure body scroll lock also works on ios safari --------- Co-authored-by: Jeroen Claassens <support@favware.tech>
favna
added a commit
that referenced
this pull request
Aug 24, 2024
* feat(markdown): add subtext * feat(clan-tags): add clan tag base * fix: remove old subtext code * feat(clan-tag): add to reply WIP * fix: clan tags working as expected Clan tags support both dark and light themes, and also normal and compact modes. Also updated timestamps component to ensure no wrapping as happens with discord. * fix: removing timestamp update * fix: add clan icon files * fix: add clan map * fix: make dynamic clan icon work * fix: image not showing * fix: finalize icons and add examples * fix: small log cleanup * fix: rename heart.ts This was already renamed on my pc github must have eaten it up. * add: New arguments in the modal (#453) * feat: adding new "error" message I was using the modals recently and I saw that there is one more message in a specific circumstance so I added that message, added new attributes to the class and repositioned the messages * add: function to show new "error" message Added a function to show the new "error" message * Update DiscordModal.ts * Update DiscordInputText.ts * fix: Change "minimum characters" message display Here I added a function to make the "error" message of minimal characters "disappear" when closing the modal * fix: Fixing some verification errors and adding a listener I added an extra check on line 410, because as it was, it didn't show the minimum character message in short inputs, and I added a listener so that every time the modal is closed the minimum characters "error" disappears * fix: some small fixes for validations * fix: change ! To ? * fix: various fixes - ensured validation cases work properly - ensure warnings properly get removed on closing * Fix: Solving Value Not Returning to Default * fix: remove unnecessary type * fix: Closing unclosed tag and fixing indentation * fix: remove accidental console.log * Fix: Fixed issue of looping the default value * Update DiscordInputText.ts * add: Adding an example of a default value in the modal * Fix: Adding More Verification Adding minimum size verification, now only the minimum size message will appear in some cases the same as discord - When the field is required - When the value of the field is greater than 1 character and less than the minimum I added this check because before there was none and it always showed the message even if the inputtext was not necessary * fix: Changing a atributte of class and add news arguments Here i changed the atribute "hasWarning" to public for use in modal class (more for polishing) e adicionei mais algumas verificações especificas na contagem de caracters (again to polishing) * fix: changing variable in verification Here a changed the variable "defaultValue" for the "value" in line 352 and 353,in view of that the variable "value" recieves the variable "defaultValue" * fix: ensure body scroll lock also works on ios safari --------- Co-authored-by: Jeroen Claassens <support@favware.tech> * feat: adding function if you click an option (#461) * feat: adding function if you click an option I added an argument to the class to execute a function by clicking on the selection if the person wants (I saw this in modal) * fix: orrecting Indentation * fix: prevent timestamp wrapping (#462) Discord doesnt have wrapping on timestamps, so this ensures no wrapping. Co-authored-by: Jeroen Claassens <support@favware.tech> * fix: update the ephemeral eye icon (#460) * refactor: better emoji parsing (#458) * refactor: update getGlobalEmojiUrl to parse Discord emoji syntax and inline emojis in titles/fields * Add animated to regex directly Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl> * chore: really ignore ignored worsd --------- Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl> Co-authored-by: Jeroen Claassens <support@favware.tech> * chore: fix merge * refactor: cleanup and fixes --------- Co-authored-by: Dominik Koch <dominik@koch-bautechnik.de> Co-authored-by: dpaulos6 <itzframepvp@outlook.com> Co-authored-by: Marciel404 <48138111+eumarciel404@users.noreply.github.com> Co-authored-by: Digital <github@crni.xyz>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.