-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci: complete all sample tests even if one fails fast #2386
Conversation
Hmmm... This Node.js CI / build (18.x) (pull_request) to Node 18 🤔 A few other errors with samples are appearing, but I'll investigate these. For now, here's what the update shows as!: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 36 36
Lines 7472 7472
Branches 653 653
=======================================
Hits 6919 6919
Misses 545 545
Partials 8 8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this behavior 👍
This can help to quickly determine which samples/examples are affected by a given change. Especially in the scenario where dependabot updates dependencies
@WilliamBergamin Thanks for calling out the multiplication of matrix updates from @dependabot! 👾 I think a fun follow-up PR will put this all of the test after this is merged 👀 |
Summary
This PR runs all of the sample tests to completion even if one fails fast. This is useful in finding if a test is failing for a certain sample or version of Node 👁️🗨️
Preview
Before this change is shown below:
Requirements