Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX: Minor Merge Fixes #41

Merged
merged 2 commits into from
Sep 3, 2024
Merged

FIX: Minor Merge Fixes #41

merged 2 commits into from
Sep 3, 2024

Conversation

zdomke
Copy link
Collaborator

@zdomke zdomke commented Aug 29, 2024

A couple of minor merge fixes:

  • Fixing syntax error in ArchiveViewer.__init__
  • timespan was renamed to self.timespan
  • Adding blank line between functions
  • Moving Slots to end of class declaration

@aksharsarvesh
Copy link
Collaborator

I like this - my mistake for some of these issues; They are currently fixed on my open PRs, which means there will be more merge conflicts when this one goes through but this should be the highest priority PR, before anything else goes through

@zdomke
Copy link
Collaborator Author

zdomke commented Sep 3, 2024

Just moving forward with merging this PR since it's straightforward.

@zdomke zdomke merged commit d76b88c into slaclab:main Sep 3, 2024
0 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants