Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ENH: EGU Axes #59

Merged
merged 1 commit into from
Sep 25, 2024
Merged

ENH: EGU Axes #59

merged 1 commit into from
Sep 25, 2024

Conversation

aksharsarvesh
Copy link
Collaborator

Couldn't get away from this work huh. Well I've created a new fork to handle the fact that there were a million untracked files in my local as a result of the name change. I copied over my changes from my open PR EGUAxes on my old repo, and it works to my knowledge. Not sure what has been added in the past week so please double check for me I didn't break anything, but I believe there were no actual merge conflicts, only that the files the old PR were changing no longer existed.

Hope this works!

Copy link
Collaborator

@zdomke zdomke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and it works great! I took notes on some things I might fix in another PR so that we can merge this one in.

@zdomke zdomke merged commit 79e6a94 into slaclab:main Sep 25, 2024
0 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants