Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug Report] Player stats files are loaded even if 'player_statistic' is disabled #97

Closed
sladkoff opened this issue Jun 23, 2021 · 0 comments
Closed

[Bug Report] Player stats files are loaded even if 'player_statistic' is disabled #97

sladkoff opened this issue Jun 23, 2021 · 0 comments
Labels
bug
Milestone
2.4.2

Comments

@sladkoff
Copy link
Owner

When player_statistic: false is set in the config, the logs indicate that PlayerStatisticLoaderFromFile still attempts to load and read statistics from the stats directory as described in #96.

This is unnecessary.
@sladkoff sladkoff added the bug label Jun 23, 2021
@sladkoff sladkoff modified the milestones: 2.5.0, 2.4.2 Jun 23, 2021
sladkoff added a commit that referenced this issue Jun 24, 2021
@sladkoff
#97: Add failing test
118ada1
sladkoff added a commit that referenced this issue Jun 24, 2021
@sladkoff
#97: Lazy load player stats file
9f2c1cf
sladkoff added a commit that referenced this issue Jun 24, 2021
@sladkoff
#97: Add failing test
ac91f00
sladkoff added a commit that referenced this issue Jun 24, 2021
@sladkoff
#97: Lazy load player stats file
c85b954
@sladkoff sladkoff mentioned this issue Jun 24, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.4.2
Development

No branches or pull requests
1 participant
@sladkoff