Improve performance of chunk loaded metric and offline player count #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed spike of mspt on regular interval and upon inspection noticed that the main contributor are three metrics of the plugin:
For players total metric. Solution:
For loaded chunks count. It looks like the
getLoadedChunks()
method makes a copy of all the chunks, which is extremely slow when there are many chunks loaded. Solution:Regarding entities, it is also possible to do same approach as with chunks, but this will be a bit more effort.