Add villager metrics #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Count number of villager per world, profession, villager type, level
- Unit test villager metric
- update config unit test
- Share 'getEntityName' between entity and villager metrics
- Slight improvement of foreach in entity metric
- Update README for new villager metric
- version bump
|
Rebased and merged manually. Thanks @aSemy! |
sladkoff
added a commit
that referenced
this pull request
Apr 13, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a metric to count how many villagers there are. These are labelled by world type (desert, plains, etc), profession, and level.
I'm not sure what the performance impact of having 4 labels could be - do you think it will be okay? I think the 'level' label could be removed at the least.
README has been updated, unit tests added/updated, and I've bumped the version number.
I also tidied up the code a bit (unused imports, that sort of thing).
Grafana stacked graph: