Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable consumption of 'omit-parsing' flag to disable #125

Merged
merged 2 commits into from
Jun 19, 2015

Conversation

arlandism
Copy link
Contributor

This is a first pass #121.

Notably, it only handles the command-line invocation case. I was en route to tackling the other use-case but I can't understand the identity check in standard.clj. I tried running a single file to inspect the active-runner and default-runner. They were the same class but not the same instance. Given that, I'm not actually sure under what circumstances that check would return true. Any insight here would be much appreciated.

Uses:
lein spec -p
lein spec --omit-pending

pending messages from test output
@arlandism
Copy link
Contributor Author

@trptcolin @slagyr Either of you have bandwidth to check this out?

@arlandism
Copy link
Contributor Author

Bump

@slagyr
Copy link
Owner

slagyr commented May 26, 2015

Are these the same flags use in rspec?

@slagyr
Copy link
Owner

slagyr commented May 26, 2015

Check out default-config and with-config. A default setting for omit-pending should be added to the default and interpreted by with-config.

The identity check will pass when you run an individual spec file, without the runner.

 java -cp `lein classpath` clojure.main spec/clj/speclj/running_spec.clj

Note the file has a (run-specs) at the bottom. This call could include options:

(run-specs :color true :omit-pending true)

Otherwise, commit looks good. Thanks for the help and sorry for the delay.

@arlandism
Copy link
Contributor Author

Thanks for the response, @slagyr. Working on this...

@arlandism
Copy link
Contributor Author

@slagyr I think it's handled. FYI, here's how things look:

Original:

[arlandislawrence@charon-2:~/dev/projects/clojure/speclj on omit-pending]
% lein spec                                                                                                                                                                                           ✹ ✭
Rewriting src/cljx to target/src/clj (clj) with features #{clj} and 0 transformations.
Rewriting src/cljx to target/src/cljs (cljs) with features #{cljs} and 1 transformations.
Rewriting spec/cljx to target/spec/clj (clj) with features #{clj} and 0 transformations.
Rewriting spec/cljx to target/spec/cljs (cljs) with features #{cljs} and 1 transformations.
..................................*.................................................*............................................................................................................................................................................................

Pending:

  Running tracks one pass
    ; Not Yet Implemented
    ; /Users/arlandislawrence/dev/projects/clojure/speclj/spec/clj/speclj/running_spec.clj:23

Finished in 0.25557 seconds
271 examples, 0 failures, 1 pending

With feature:

[arlandislawrence@charon-2:~/dev/projects/clojure/speclj on omit-pending]
% lein spec -p                                                                                                                                                                                        ✹ ✭
Rewriting src/cljx to target/src/clj (clj) with features #{clj} and 0 transformations.
Rewriting src/cljx to target/src/cljs (cljs) with features #{cljs} and 1 transformations.
Rewriting spec/cljx to target/spec/clj (clj) with features #{clj} and 0 transformations.
Rewriting spec/cljx to target/spec/cljs (cljs) with features #{cljs} and 1 transformations.
..................................*.................................................*............................................................................................................................................................................................

Finished in 0.24588 seconds
271 examples, 0 failures, 1 pending

slagyr added a commit that referenced this pull request Jun 19, 2015
Enable consumption of 'omit-parsing' flag to disable
@slagyr slagyr merged commit ace4d18 into slagyr:master Jun 19, 2015
@slagyr
Copy link
Owner

slagyr commented Jun 19, 2015

Nice work. Thanks for the contribution Arlandis? This will be included in the next release 3.3.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants