-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enable consumption of 'omit-parsing' flag to disable #125
Conversation
pending messages from test output
@trptcolin @slagyr Either of you have bandwidth to check this out? |
Bump |
Are these the same flags use in rspec? |
Check out default-config and with-config. A default setting for omit-pending should be added to the default and interpreted by with-config. The identity check will pass when you run an individual spec file, without the runner.
Note the file has a (run-specs) at the bottom. This call could include options:
Otherwise, commit looks good. Thanks for the help and sorry for the delay. |
Thanks for the response, @slagyr. Working on this... |
@slagyr I think it's handled. FYI, here's how things look: Original:
With feature:
|
Enable consumption of 'omit-parsing' flag to disable
Nice work. Thanks for the contribution Arlandis? This will be included in the next release 3.3.0. |
This is a first pass #121.
Notably, it only handles the command-line invocation case. I was en route to tackling the other use-case but I can't understand the identity check in
standard.clj
. I tried running a single file to inspect theactive-runner
anddefault-runner
. They were the same class but not the same instance. Given that, I'm not actually sure under what circumstances that check would return true. Any insight here would be much appreciated.Uses:
lein spec -p
lein spec --omit-pending