Support .cljc specs #150
Merged
Support .cljc specs #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates the discrepancy between Clojure and ClojureScript classes for speclj.platform.SpecFailure and speclj.platform.SpecPending
|
Interesting... makes sense. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #133, by eliminating the discrepancy between Clojure and ClojureScript classes for
SpecFailureandSpecPending. It made sense to me that both should be inspeclj.platform, since they are essentially platform-specific implementations of the same APIs.I verified this against the test repo and instructions provided by milt in #133, as well as in my own project where I encountered the issue.
I was unable to reproduce the issue in specs within the speclj project (in fact, it appears there are already
.cljctests running successfully), but I suspect this has something to do with a difference between how speclj's own specs are compiled and initialized, versus a typicallein-cljsbuildproject with the test runner described in README.