Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactors speclj Leiningen task and speclj.main. #67

Merged
merged 1 commit into from
Nov 11, 2013
Merged

Refactors speclj Leiningen task and speclj.main. #67

merged 1 commit into from
Nov 11, 2013

Conversation

mylesmegyesi
Copy link
Contributor

Instead of launching a new JVM to run tests, run the tests in the leiningen JVM. On my machine, this patch
decreases the amount of time to run lein spec from 6 secs down to 3
secs for the speclj test suite.

Instead of launching a new JVM to run tests, run the tests in the leiningen JVM. On my machine, this patch
decreases the amount of time to run `lein spec` from 6 secs down to 3
secs for the speclj test suite.
slagyr added a commit that referenced this pull request Nov 11, 2013
Refactors speclj Leiningen task and speclj.main.
@slagyr slagyr merged commit 68186a7 into slagyr:master Nov 11, 2013
@technomancy
Copy link

This is not a good idea; it will not work for many projects. If a project wants to run in Leiningen, they should just set :eval-in :leiningen themselves and it will have the same effect.

@slagyr
Copy link
Owner

slagyr commented Feb 26, 2014

Resolved. The lein spec task will set :eval-in :subprocess by default but users can override this by setting :speclj-eval-in :leiningen. This way they can avoid setting :eval-in in their projects.clj which could have other undesirable effects.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants