Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Customizing reporters #69

Merged
merged 2 commits into from
Nov 11, 2013
Merged

Customizing reporters #69

merged 2 commits into from
Nov 11, 2013

Conversation

alpian
Copy link

@alpian alpian commented Nov 7, 2013

Allow an implementation of Reporter to be passed into the reporters configuration to simplify the process of supplying your own reporter.

Also add clojure.test as a default reporter

slagyr added a commit that referenced this pull request Nov 11, 2013
@slagyr slagyr merged commit 1a55452 into slagyr:master Nov 11, 2013
@slagyr
Copy link
Owner

slagyr commented Nov 11, 2013

I'd like to release with this included but I'm experiencing a problem. See below. Also, would you please update specjl.cli/arg-spec with the new builtin reporter?

$ lein spec -f clojure-test
java.lang.NullPointerException
at clojure.core$deref_future.invoke(core.clj:2108)
at clojure.core$deref.invoke(core.clj:2129)
at speclj.report.clojure_test.ClojureTestReporter.report_runs(clojure_test.clj:75)
at speclj.reporting$report_runs_STAR_.invoke(reporting.clj:97)
at speclj.run.standard.StandardRunner.run_and_report(standard.clj:43)
at speclj.run.standard.StandardRunner.run_directories(standard.clj:30)
at speclj.cli$do_specs$fn__1240.invoke(cli.clj:85)

@alpian
Copy link
Author

alpian commented Nov 11, 2013

Great! Thanks for accepting the pull-request! I will update arg-spec. I did see that NPE, but only intermittently and figured it had gone away - i will take another look asap :).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants