Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix for inproper exit-code on spec failures #90

Merged
merged 1 commit into from
Jun 13, 2014
Merged

Fix for inproper exit-code on spec failures #90

merged 1 commit into from
Jun 13, 2014

Conversation

CraZySacX
Copy link
Contributor

This change should resolve issue #81 where lein spec was always exiting with an exit-code of 0. This should allow for proper CI integration. The exit-if-needed function appeared to always be receiving nil, and therefore evaluating to 0 in every case.

@CraZySacX
Copy link
Contributor Author

Any chance on this getting in? I'm currently using my fork successfully with Travis, would be nice to be in master.

@sdegutis
Copy link
Contributor

sdegutis commented Jun 3, 2014

I would merge it, but I haven't fully looked through it yet to make sure I fully understand what it does in the patch and what it used to do. I'll try to look through it in the next few days. Hopefully I can do so before @slagyr cuts the next release.

@CraZySacX
Copy link
Contributor Author

Sounds good, thanks. Let me know if you have any questions. Basically, in the before code, the exit-code was always evaluating to 0, which causes issues with CI systems that rely on a non-zero exit-code when errors occur. The new code evaluates to 0 if all the tests are successful, or evaluates to the number of failed tests (up to 250) if there are failures.

sdegutis pushed a commit that referenced this pull request Jun 13, 2014
Fix for inproper exit-code on spec failures
@sdegutis sdegutis merged commit 4368531 into slagyr:master Jun 13, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants