Handle non-github.heygears.com links properly in LinkParser

slapperwan · Nov 5, 2021 · 07ba31b · 07ba31b
1 parent 6a7d04f
commit 07ba31b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/app/src/main/java/com/gh4a/resolver/LinkParser.java b/app/src/main/java/com/gh4a/resolver/LinkParser.java
@@ -59,6 +59,10 @@ public static ParseResult parseUri(FragmentActivity activity, @NonNull Uri uri,
             return parseNewBlogLink(activity, parts);
         }
 
+        if (!"github.com".equals(uri.getHost())) {
+            return null;
+        }
+
         if (parts.isEmpty()) {
             return null;
         }

diff --git a/app/src/test/java/com/gh4a/resolver/LinkParserTest.java b/app/src/test/java/com/gh4a/resolver/LinkParserTest.java
@@ -739,11 +739,6 @@ public void blobLink_withoutBranchAndPath__opensBrowser() {
         assertRedirectsToBrowser(parseLink("https://github.com/slapperwan/gh4a/blob"));
     }
 
-    @Test
-    public void compareLink__redirectsToCompareView() {
-
-    }
-
     @Test
     public void compareLink_withoutRefs__opensBrowser() {
         LinkParser.ParseResult result =
@@ -768,6 +763,11 @@ public void unknownRepositoryLink__opensBrowser() {
         assertRedirectsToBrowser(parseLink("https://github.com/slapperwan/gh4a/unknown"));
     }
 
+    @Test
+    public void nonGitHubDotComLink__opensBrowser() {
+        assertRedirectsToBrowser(parseLink("https://user-images.githubusercontent.com/30041551/an_image.png"));
+    }
+
     private LinkParser.ParseResult parseLink(String uriString) {
         return LinkParser.parseUri(mActivity, Uri.parse(uriString), null);
     }