URL resolution improvements #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling for special GitHub URL segments that the app previously treated mistakenly as GH users (such as /issues, /notifications, /timeline etc.).
The list of GitHub reserved names was also greatly expanded with page names of their website (all added pages have been manually checked).
I've also made a performance tweak to the RefPathDisambiguationTask, so that it doesn't unnecessarily try to resolve the ref to a branch/tag name when the ref is a SHA1. I don't think anyone sane would name a branch like
<full SHA1>/something😅