Add rocket and eyes reactions in diff viewer too #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, rocket and eyes comment reactions were never displayed in the diff viewer.
The SVG
paths have been taken from the corresponding vector drawables (since the eyes icon drawable has 2paths, I've merged them into a single one).I've also included a small tweak to the way references to commits in other repos are displayed in the timeline, so that it's more consistent with how GitHub commits autolinks work.
I'd also like to make some improvements to the appearance of comments in the diff viewer, but I'll likely conflict with #1180. Please try out that one when you have some time 🙏