Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve text sizes in Markdown rendering #1205

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Conversation

Fs00
Copy link
Contributor

@Fs00 Fs00 commented May 21, 2022

I've made a couple of adjustments regarding text sizes to Markdown rendering in comments/Readme:

  • subscript/superscript text is now smaller, to make it look as it does in GitHub web UI
  • sizes of H1 to H6 has been changed to make the different types of heading more clearly distinguishable. Previously I had a hard time finding the difference between an H1 and an H2, or between an H2 and an H3. You can see below the difference:
BeforeAfter

@Fs00
Copy link
Contributor Author

Fs00 commented Jul 28, 2022

@maniac103 Can this be merged too? Any doubts?

@maniac103
Copy link
Collaborator

The only thing I have doubts about is that I'm not sure about H6 size being smaller than normal text.

@Fs00
Copy link
Contributor Author

Fs00 commented Jul 28, 2022

I thought it was fine because I've seen that the GitHub UI makes H6 even smaller than we do (on the GH website H6 are 85% of the normal text size compared to 90% in this PR).

An alternative I see is to make H6 as big as normal text and H5, but change their color to a dark shade of grey (both the GitHub UI and our Markdown CSS use this approach).

@maniac103
Copy link
Collaborator

If they're doing the same thing it's fine I guess.

@maniac103 maniac103 merged commit 876955b into slapperwan:master Jul 28, 2022
@Fs00 Fs00 deleted the text-sizes branch July 28, 2022 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants