Skip to content

Commit

Permalink
jsonnet/main.jsonnet: Override containerfsSelector
Browse files Browse the repository at this point in the history
container_fs_.* metrics doesn't have "container" label after
openshift/pull/1402 which caused regression
for dashboards using "container" label since it gives empty datapoints
for all queries using "container" label in queries containing
container_fs_.* metrices.

Inorder to fix the dashboards added containerfsSelector in
kubernetes-monitoring/kubernetes-mixin/pull/737 and overrided the containerfsSelector
default value from  container!="" to harmless id!="" in this commit.
We really don't need that selector since we dropped the container label
in OCP for container_fs_.* metrices but we need to override the
selector for the queries involving container_fs_.* to work.
  • Loading branch information
slashpai committed Jun 21, 2022
1 parent 55e050f commit c8b96bf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions jsonnet/main.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ local inCluster =
cpuThrottlingSelector: $.values.common.mixinNamespaceSelector,
kubeletPodLimit: 250,
pvExcludedSelector: 'label_alerts_k8s_io_kube_persistent_volume_filling_up="disabled"',
containerfsSelector: 'id!=""',
},
},
},
Expand Down

0 comments on commit c8b96bf

Please # to comment.