Skip to content

Use GitHub Actions instead of Travis CI #309

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Dec 8, 2020

Conversation

josephfrazier
Copy link
Collaborator

@josephfrazier josephfrazier commented Dec 8, 2020

Travis CI is no longer providing CI minutes for open source projects: https://news.ycombinator.com/item?id=25338983

It's also been pretty slow: the build for #308
hasn't started in 13 minutes

The config file is based on the template at https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-nodejs#specifying-the-nodejs-version

Travis CI is no longer providing CI minutes for open source projects: https://news.ycombinator.com/item?id=25338983

It's also been pretty slow: the build for slevithan#308
hasn't started in 13 minutes
@josephfrazier josephfrazier marked this pull request as ready for review December 8, 2020 03:55
@slevithan
Copy link
Owner

Can we also replace the Travis CI build status badge at the top of README.md with something equivalent?

@josephfrazier
Copy link
Collaborator Author

Good call, I'll try to see if I can find something.

It looks like we'll need to manually enable the workflow once this is merged: https://docs.github.com/en/free-pro-team@latest/actions/managing-workflow-runs/disabling-and-enabling-a-workflow

But, I'm still working on fixing a bug in it: https://github.com/josephfrazier/xregexp/actions/runs/407379254

@slevithan
Copy link
Owner

Good call, I'll try to see if I can find something.

Maybe it's for the best to just kill the badge anyway, since the readme shows up on npm and elsewhere.

@@ -1,6 +1,6 @@
# XRegExp 4.4.0

[![Build Status](https://travis-ci.org/slevithan/xregexp.svg?branch=master)](https://travis-ci.org/slevithan/xregexp)
[![Build Status](https://github.com/slevithan/xregexp/workflows/.github/workflows/build.yml/badge.svg)](https://github.com/slevithan/xregexp/actions)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it should work, but we can check once it's merged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #310

@josephfrazier
Copy link
Collaborator Author

But, I'm still working on fixing a bug in it: josephfrazier/xregexp/actions/runs/407379254

ok, looks like we're good now: https://github.com/josephfrazier/xregexp/runs/1515139490?check_suite_focus=true

@josephfrazier josephfrazier merged commit 96ea7b1 into slevithan:master Dec 8, 2020
@josephfrazier josephfrazier deleted the joseph/github.actions branch December 8, 2020 04:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants