Skip complexity calculation by directiveEstimator when astNode is undefined #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, I'm using Apollo Server 2 with Federation.
In QueryComplexity.ts, I found that
field
inestimatorArgs
could haveundefined
value inastNode
property.And if we use
DirectiveEstimator
,args.field.astNode
in this line could beundefined
and makegetDirectiveValues
throws error.So it's better to set default value of
field.astNode
to an empty object{}
.These are which I printed from
field
:Update: Skip complexity calculation by
directiveEstimator
whenastNode
isundefined