Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix composer scripts #2845

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

piotr-cz
Copy link
Contributor

When trying to run composer scripts, instead of executing their file is printed on screen.
For example

composer phpunit
> php vendor/bin/phpunit

dir=$(cd "${0%[/\\]*}" > /dev/null; cd "../phpunit/phpunit" && pwd)

if [ -d /proc/cygdrive ]; then
    case $(which php) in
        $(readlink -n /proc/cygdrive)/*)
            # We are in Cygwin using Windows php, so the path must be translated
            dir=$(cygpath -m "$dir");
            ;;
    esac
fi

"${dir}/phpunit" "$@"

Fixed by adjusting to suggestions:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 87a1c45 on piotr-cz:bugfix/composer-scripts into 62b7295 on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.3.0 milestone Sep 24, 2019
@l0gicgate
Copy link
Member

We should probably fix that on all the repos @adriansuter

@l0gicgate l0gicgate merged commit b63b7d4 into slimphp:4.x Sep 24, 2019
@piotr-cz piotr-cz deleted the bugfix/composer-scripts branch September 24, 2019 16:31
@adriansuter
Copy link
Contributor

@l0gicgate Yes, we should.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants