Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow ^1.0 || ^2.0 in psr/container #3063

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Allow ^1.0 || ^2.0 in psr/container #3063

merged 1 commit into from
Mar 8, 2021

Conversation

Ayesh
Copy link
Contributor

@Ayesh Ayesh commented Mar 6, 2021

FIG released a new version of psr/container today. The new 2.x series has parameter types and return types, but it does not remove any methods.

Technically, we are compatible with any psr/container ^1.0 || ^2.0 implementation. This PR updates the required psr/container versions to include 2.x as well, so users can use any psr/container implementation, including ones that implement the new version.

I use my own container implementation with phpwatch/simple-container, that just tagged 2.0.0 with psr/container ^2.0 requirement. I think other containers will follow suit in coming weeks.

Thank you.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6c71e5d on Ayesh:psr-container2 into bdc423b on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.8.0 milestone Mar 8, 2021
@l0gicgate
Copy link
Member

We should do this on all the other repos as well. Thank you for your contribution @Ayesh

@l0gicgate l0gicgate merged commit 090498e into slimphp:4.x Mar 8, 2021
@odan odan mentioned this pull request Jul 26, 2022
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants