POC: Add new Error type for the public API
#231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hide implementation details `ExceptionResponse` will be added to the public API. Its fields must now be `private` and not be accessible to users of the library.
…`ExceptionResponse` This propose a simple API to use `ExceptionResponse`.
The `Error` type is a specialization of the `Error` type for modbus communication. The `Result` type is a specialization of the `Result` type with the modbus `Error` as error variant.
benjamin-nw
changed the title
Error type for the public APIError type for the public API
…t/server/service public API
…o_modbus::Error`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a PoC to show an implementation with an
Errorand aResulttype for thetokio-modbuscrate.The goal of the PoC is to test if updating the
std::io::Errorinto acrate::error::Errorcan be an effective solution to better handleExceptionreturned by a modbus server.Working examples:
rtu-client-sync.rsrtu-client.rsrtu-server-address.rsrtu-server.rstcp-client-custom-fn.rstcp-client-sync.rstcp-client.rstcp-server.rstls-client.rstls-server.rsPlease, feel free to review this PR anytime.