Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Disable max. PDU size checks for custom functions #307

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Disable max. PDU size checks for custom functions #307

merged 2 commits into from
Dec 12, 2024

Conversation

uklotzde
Copy link
Member

Fixes #306.

@uklotzde uklotzde added this to the v0.16.1 milestone Dec 12, 2024
@uklotzde uklotzde requested a review from flosse December 12, 2024 12:03
@uklotzde uklotzde mentioned this pull request Dec 12, 2024
Closed
@uklotzde
Copy link
Member Author

The size checks could be omitted for all fixed size requests/responses, because we also check that all bytes have been consumed.

@uklotzde
Copy link
Member Author

Confirmed to work as expected. The unconditional check seems to be too restrictive for custom function codes.

@uklotzde uklotzde merged commit 5e0f20d into slowtec:main Dec 12, 2024
10 checks passed
@uklotzde uklotzde deleted the max_pdu_size branch December 12, 2024 22:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@flosse flosse Awaiting requested review from flosse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New MAX_PDU_SIZE limits systems that work beyond that limit via custom functions
1 participant
@uklotzde