chore: Revert "fix: upload-artifact and download-artifact v4" #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b595e06.
ramonpetgrave64
requested review from
laurentsimon,
joshuagl and
kpk47
as code owners
|
@laurentsimon @ianlewis . Regarding recent breaking changes, I think this is the only one that we must revert. |
laurentsimon
changed the title
|
Thanks, let's merge this one in. I think we also need to revert the one on the attestation-name option deprecation. Can you send a similar reverting PR to example-package? |
laurentsimon
approved these changes
Mar 20, 2024
|
Pre-submit failing due to using upload-artifact at v3 but download-artifact at v4 which are incompatible. I'll disable that particular check to merge this PR. |
|
secure-upload-folder pre-submit re-enabled |
ramonpetgrave64
added a commit
that referenced
this pull request
Apr 3, 2024
…act v4"" (#3499) Reverts #3398 Following up with - slsa-framework/example-trw#3 - slsa-framework/example-package#340 - slsa-framework/slsa-verifier#719 Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
ramonpetgrave64
deleted the
revert-3312-ramonpetgrave64-upload-download-artifact-v4
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3312
#3393