Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for scoped npm modules #32

Merged
merged 4 commits into from
Feb 24, 2015

Conversation

doctyper
Copy link
Contributor

Hello,

  • This pull request introduces support for scoped npm modules. We currently have a need for this in my organization. Nutshell: Slush is now able to find modules like @company/slush-foo.
  • I have also added the ability to detect paths via process.env.NODE_PATH in an effort to avoid hard-coded paths.
  • I've also stopped converting paths to lower case, to address Issues with OSX and case sensitive filesystem #17.
  • Lastly, I've fixed a failing test (it was failing before my edits).

I'd love to see this land soon! Let me know if you have issues / questions / concerns.

@joakimbeng
Copy link
Member

@doctyper great work! Thanks!

joakimbeng pushed a commit that referenced this pull request Feb 24, 2015
Add support for scoped npm modules and NODE_PATH env var
@joakimbeng joakimbeng merged commit 2383fd2 into slushjs:master Feb 24, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants