Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cstdint is required #45

Closed
wants to merge 2 commits into from
Closed

cstdint is required #45

wants to merge 2 commits into from

Conversation

mattn
Copy link

@mattn mattn commented Aug 26, 2021

No description provided.

@smacker
Copy link
Owner

smacker commented Sep 22, 2021

Could you please clarify why cstdint is required? The test for yaml parser passes correctly for me.

@mattn
Copy link
Author

mattn commented Sep 22, 2021

int8_t is defined in cstdint. (stdint.h for C)

image

@smacker
Copy link
Owner

smacker commented Sep 26, 2021

Hi @mattn . As you correctly pointed out, the type definition is already included in stdint.h which is imported in the parser that results in a correct build.

Though I do understand your concern. Please open an issue or PR to the yaml-grammar repository instead. This project provides binding to Golang only. I will be happy to update the version of the grammar after the changes merged and released.

Thank you.

@smacker smacker closed this Sep 26, 2021
@mattn
Copy link
Author

mattn commented Sep 26, 2021

Sure. ikatyang/tree-sitter-yaml#31

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants