Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add API for reconstructing descriptors and generic signatures #293

Merged

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jan 10, 2023

This API includes type variable substitution, which is used on several places in Quarkus. If the substitution function returns a type for some type variable identifier, the reconstructed descriptor/signature contains a descriptor/signature of the provided type instead of the original type variable.

@Ladicek Ladicek added this to the 3.1.0 milestone Jan 10, 2023
@Ladicek Ladicek marked this pull request as draft January 10, 2023 16:21
@Ladicek
Copy link
Contributor Author

Ladicek commented Jan 10, 2023

Draft for now, as I need to test if the changes here are sufficient for Quarkus usage of the type variable substitution feature.

This API includes type variable substitution, which is used on several
places in Quarkus. If the substitution function returns a type for some
type variable identifier, the reconstructed descriptor/signature contains
a descriptor/signature of the provided type instead of the original type
variable.
@Ladicek Ladicek force-pushed the descriptor-and-signature-reconstruction branch from ced4f27 to fd51c25 Compare January 13, 2023 12:32
@Ladicek Ladicek marked this pull request as ready for review January 13, 2023 15:53
@Ladicek Ladicek merged commit 559bb46 into smallrye:main Jan 13, 2023
@Ladicek Ladicek deleted the descriptor-and-signature-reconstruction branch January 13, 2023 16:05
@Ladicek Ladicek linked an issue Mar 20, 2023 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add methods to reconstruct generic signature
1 participant