improve performance of the annotation overlay #495
Merged
+330
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's several improvements in this commit: 1. Transformed annotations are always cached, even if no transformation applied. This makes it much faster in the most common case, while adding no significant memory overhead, because vast majority of objects already existed. 2. The transformation context implementation creates a copy of annotations lazily, on the first need. Again, this makes it much faster in the most common case (which is no annotation transformations applied). 3. Several copies were eliminated because they were just unnecessary overhead. For example, `AnnotationTarget.annotations()` or `declaredAnnotations()` already return unmodifiable collections, so there's no need to rewrap them again. 4. The [potentially transformed] annotations are no longer stored as a `Set` but as a `Collection`. This saves several copies and doesn't affect public API, which has always been defined in terms of `Collection`s. 5. Lambdas in `AnnotationOverlayImpl` were replaced by annonymous classes. The [modest] usage of streams was eliminated completely.
The benchmark is rather simplistic and cannot be used in isolation. A real-world benchmark needs to be used as well.
gsmet
approved these changes
Feb 11, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #494