Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Polish up provisioners.mdx #236

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Linda-Ikechukwu
Copy link
Contributor

This pull request suggests several wording edits to the provisioner doc page:

  • Removing future tense in favor of present tense
  • Change passive voice to active voice
  • Changing plural to singular in several instances
  • Spelling out terms in clear on the first use before introducing an acronym
  • Several other wording and styling edits

Suggesting several wording edits. 
- Removing future tense in favor of present tense
- Changing plural to singular in several instances
- Spelling out terms in clear on the first use before introducing an acronym
- Several other wording and styling edits
@Linda-Ikechukwu Linda-Ikechukwu requested a review from a team as a code owner May 19, 2023 19:52
@tashian tashian self-requested a review May 22, 2023 18:31
@tashian
Copy link
Contributor

tashian commented May 22, 2023

Looking good @Linda-Ikechukwu, just added a few suggestions.

Linda-Ikechukwu and others added 5 commits May 25, 2023 13:50
Co-authored-by: Carl Tashian <carl@smallstep.com>
Co-authored-by: Carl Tashian <carl@smallstep.com>
Co-authored-by: Carl Tashian <carl@smallstep.com>
@Linda-Ikechukwu Linda-Ikechukwu requested a review from tashian May 26, 2023 15:51
- Add the link to database page
- Add explanation for reason to delete JWK encrypted private key.
Copy link
Contributor

@tashian tashian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tashian
Copy link
Contributor

tashian commented Jul 25, 2023

@Linda-Ikechukwu just saw this old PR here with your updates in it. Feel free to merge this one if you think it's ready

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants