Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add png asset #27

Merged
merged 1 commit into from
Aug 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ const nodeBuilder = new ScratchWebpackConfigBuilder(common)
}
})
.addModuleRule({
test: /\.mp3$/,
type: 'asset'
test: /\.(svg|png|wav|mp3|gif|jpg)$/,
resourceQuery: /^$/, // reject any query string
type: 'asset' // let webpack decide on the best type of asset
});

const webBuilder = new ScratchWebpackConfigBuilder(common)
Expand All @@ -45,8 +46,9 @@ const webBuilder = new ScratchWebpackConfigBuilder(common)
}
})
.addModuleRule({
test: /\.mp3$/,
type: 'asset'
test: /\.(svg|png|wav|mp3|gif|jpg)$/,
resourceQuery: /^$/, // reject any query string
type: 'asset' // let webpack decide on the best type of asset
})
.addModuleRule({
test: require.resolve('./src/index.js'),
Expand Down
Loading