Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Provide a readable explanation when git command is not available #6

Closed
smarie opened this issue Jan 13, 2020 · 2 comments
Closed

Provide a readable explanation when git command is not available #6

smarie opened this issue Jan 13, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@smarie
Copy link
Owner

smarie commented Jan 13, 2020

When 'git' command is not in path, setuptools_scm get_version does not provide a readabale explanation. We should therefore rather check it upfront

from setuptools_scm import has_command
has_command('git')
@smarie smarie added the enhancement New feature or request label Jan 13, 2020
@smarie
Copy link
Owner Author

smarie commented Jan 17, 2020

I will fix it for now in the code, but for the long term it seems much more relevant to have it in setuptools_scm directly. I therefore opened pypa/setuptools-scm#392

@smarie smarie closed this as completed in 3c20e5f Jan 17, 2020
@smarie
Copy link
Owner Author

smarie commented Jan 17, 2020

Fixed in 0.5.8

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smarie