Use precise array type check #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- refactor handling of VmOptions to be initialized outside of VM directly based on arguments - avoids double instantiation and confusion Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
added
the
enhancement
ghost
approved these changes
Apr 10, 2017
ghost
approved these changes
Apr 10, 2017
ghost
approved these changes
Apr 10, 2017
ghost
approved these changes
Apr 10, 2017
ghost
approved these changes
Apr 10, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid use of
instanceofin favor for precise.getClass() ==check.This avoids some complexity for compilation, and potentially run time.
It doesn't have any relevant performance impact at the moment.
However, it also avoids Truffle's performance warning for
instanceof Object[], because it isn't a leaf type.@Richard-Roberts would be great if you could review this.