Simplify Object Model and add StorageAccessor #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
added
the
enhancement
smarr
force-pushed
the
object-model
branch
2 times, most recently
from
3ceadf8 to
d8b9179
Compare
Repository owner
deleted a comment from
coveralls
Jun 25, 2017
Repository owner
deleted a comment from
coveralls
Jun 25, 2017
Repository owner
deleted a comment from
coveralls
Jun 25, 2017
|
@Richard-Roberts Would be great if you could have a look at this, and potential review the change. @daumayr, I am not sure, no way to confirm, I think, but I might have fixed our long-standing race. |
smarr
force-pushed
the
object-model
branch
2 times, most recently
from
9c6c13a to
332d839
Compare
- move variability into dispatch chains and remove read/write nodes
- the goal here is to have one less indirection/moving part
didn't seem necessary anymore, and just made the model more complex
- prim (set/setOrUnset), object, unwritten variability is now in
dispatch chains directly
- do accessing of the slot's memory in a new storage accessors
- there is a fixed number of storage accessors preallocated based on
the fields in S*Object
- the goal is to have more control over the unsafe accesses and try
alternative accessors for the SubstrateVM
- expose CheckSObject guard and use it for cast
- correct naming and file structure
- move storage handling and primitiveUsedMap handling from SObject to
storage accessors
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- make sure multiple initializations of same slot don't overwrite first type but generalize it instead, if necessary - make sure already generalized fields don't need to be generalized again Signed-off-by: Stefan Marr <git@stefan-marr.de>
- only to be used on the slow path - updated only with sync on ClassFactory - also, updates should only be part of slow path Signed-off-by: Stefan Marr <git@stefan-marr.de>
It doesn’t seem very useful to have invalid layouts being propergated after such a check. Signed-off-by: Stefan Marr <git@stefan-marr.de>
|
The changes to the object model are merged now, but post-merge reviews are still welcome. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didn't seem necessary anymore, and just made the model more complex
dispatch chains directly
the fields in S*Object
alternative accessors for the SubstrateVM
storage accessors