Replace node constructors with explicit initialization #184
+599
−1,443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adapt primitive instantiation Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- avoids duplicating the same knowledge - gives us common interface for init, avoiding constructor - add corresponding classes AritySystemOperation - make sure to initialize nodes in the right order 1. set source section 2. optionally, set the eager primitive flag 3. set VM, i.e., context With this order, initializations of breakpoints and other things that require source sections and the VM, are only safe in the last step, after setting the VM. Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
prim-constructors
branch
from
2cbabed to
bc4e21b
Compare
smarr
added
the
enhancement
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes a lot of trivial constructors and thus, reduces the boilerplate code for all primitives.
However, it comes at the additional complexity of non-final fields for the source section as well as the VM, where needed.
Furthermore, it needs extra calls to
initialize(.)methods, which means we need to ensure things are initialized in the in the right order:With this order, initializations of breakpoints and other things that require source sections and the VM, are only safe in the last step, after setting the VM.