Ccip-3389 offchain view to include active jobspecs #16572

AnieeG · 2025-02-25T21:07:23Z

More comprehensible views with -

Decoded CCIPHome configs
Decoded address bytes
Active Jobspecs in nops view
Consolidate pool views

…develop

github-actions · 2025-02-25T21:22:14Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

…CCIP-3389-offchain-view

github-actions · 2025-03-05T23:16:57Z

Flakeguard Summary

Ran new or updated tests between develop and 7de33f5 (CCIP-3389-offchain-view).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
Test_AnalyzeRmnHomeSetConfig	0%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/deployment/common/proposalutils	false	10ms	@smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs-2f1a8b7b-e38d-4fe1-bfb9-91269dfd7aee.json.

github-actions · 2025-03-05T23:55:39Z

Flakeguard Summary

Ran new or updated tests between develop and e1f41d9 (CCIP-3389-offchain-view).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
Test_AnalyzeRmnHomeSetConfig	0%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/deployment/common/proposalutils	false	10ms	@smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs-dc1fe0cb-b365-4ac5-9b36-715226e5c79e.json.

github-actions · 2025-03-06T00:36:26Z

Flakeguard Summary

Ran new or updated tests between develop and 8489625 (CCIP-3389-offchain-view).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

3 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Failures	Package	Package Panicked?	Avg Duration	Code Owners
Test_RegisterNodes/no_ops_in_proposal_if_node_already_exists	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/deployment/keystone/changeset/internal	false	10ms	@smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation
Test_RegisterNodes/success_create_add_nodes/mcms	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/deployment/keystone/changeset/internal	false	10ms	@smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation
Test_RegisterNodes/success_create_add_nodes/no_mcms	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/deployment/keystone/changeset/internal	false	13.333333ms	@smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs-b401c58e-847e-4bb9-9508-9bb2d8f67388.json.

cl-sonarqube-production · 2025-03-06T00:46:59Z

Quality Gate passed

Issues
1 New issue
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

AnieeG · 2025-03-06T03:26:07Z

deployment/ccip/changeset/internal/deploy_home_chain.go

@@ -339,6 +339,7 @@ func BuildOCR3ConfigForCCIPHome(
 		if !exists {
 			return nil, fmt.Errorf("no OCR config for chain %d", destSelector)
 		}
+		p2pIDs = append(p2pIDs, node.PeerID)


nodes.PeerIDs() was returning peerids in a sorted manner which was making peerid, transmitter account , signer combination getting jumbled up later in this func. Fixed the order here

AnieeG · 2025-03-06T03:28:48Z

deployment/ccip/view/v1_6/rmnhome.go

-	OffchainPublicKey [32]byte `json:"offchainPublicKey"`
-}
-
-func (n RMNHomeNode) MarshalJSON() ([]byte, error) {


no need for custom marshal unmarshal as we are saving decode peerids and []byte type already marshals correctly to hex.EncodeToString

makramkd · 2025-03-06T09:46:24Z

deployment/ccip/changeset/view_test.go

+	// to ensure the view is valid
+	b, err := jsonData.MarshalJSON()
+	require.NoError(t, err)
+	fmt.Println(string(b))


makramkd · 2025-03-06T09:48:29Z

deployment/environment/test/jd.go

@@ -341,7 +342,8 @@ func (s *UnimplementedJobServiceClient) GetProposal(ctx context.Context, in *job

 // ListJobs implements job.JobServiceClient.
 func (s *UnimplementedJobServiceClient) ListJobs(ctx context.Context, in *jobv1.ListJobsRequest, opts ...grpc.CallOption) (*jobv1.ListJobsResponse, error) {
-	panic("unimplemented")
+	// returns blank response


nit: maybe move this comment to the doc comment and explain reasoning as to why

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

933413d

…develop

AnieeG requested review from a team as code owners February 25, 2025 21:07

AnieeG requested review from winder, asoliman92, matYang, makramkd, dimkouv, mateusz-sekara and 0xnogo February 25, 2025 21:07

AnieeG marked this pull request as draft February 25, 2025 21:07

AnieeG mentioned this pull request Feb 25, 2025

CCIP-2573: Adding Test router setup #16503

Merged

all changes

5cfac99

AnieeG force-pushed the CCIP-3389-offchain-view branch from b84301f to 5cfac99 Compare March 5, 2025 22:39

AnieeG added 3 commits March 5, 2025 14:39

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

9bb48f5

…CCIP-3389-offchain-view

fix lints

6d2882c

fix keystone tests

7de33f5

more fixes

e1f41d9

AnieeG added 2 commits March 5, 2025 16:18

more keystone test fixes

8489625

fix another

e20f9c6

AnieeG marked this pull request as ready for review March 6, 2025 01:51

AnieeG commented Mar 6, 2025

View reviewed changes

makramkd approved these changes Mar 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ccip-3389 offchain view to include active jobspecs #16572

Ccip-3389 offchain view to include active jobspecs #16572

AnieeG commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025

github-actions bot commented Mar 5, 2025

github-actions bot commented Mar 6, 2025

cl-sonarqube-production bot commented Mar 6, 2025

AnieeG Mar 6, 2025

AnieeG Mar 6, 2025

makramkd Mar 6, 2025

makramkd Mar 6, 2025

Ccip-3389 offchain view to include active jobspecs #16572

Are you sure you want to change the base?

Ccip-3389 offchain view to include active jobspecs #16572

Conversation

AnieeG commented Feb 25, 2025 • edited Loading

github-actions bot commented Feb 25, 2025 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

github-actions bot commented Mar 5, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

github-actions bot commented Mar 5, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

github-actions bot commented Mar 6, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

cl-sonarqube-production bot commented Mar 6, 2025

Quality Gate passed

AnieeG Mar 6, 2025

Choose a reason for hiding this comment

AnieeG Mar 6, 2025

Choose a reason for hiding this comment

makramkd Mar 6, 2025

Choose a reason for hiding this comment

makramkd Mar 6, 2025

Choose a reason for hiding this comment

AnieeG commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Feb 25, 2025 •

edited

Loading