evm exaction: use agnostic keystore #16577
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2025
jmank88
force-pushed
the
CRE-305-agnostic-keystore
branch
from
16dd1d4 to
d7d2583
Compare
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , GolangCI Lint (system-tests/lib) , GolangCI Lint (core/scripts) , Core Tests (go_core_race_tests) , GolangCI Lint (.) , GolangCI Lint (integration-tests/load) , GolangCI Lint (system-tests/tests) , test-scripts , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , lint , SonarQube Scan 1. Race(s) detected:[go_core_race_tests]Source of Error:+ EXITCODE=1
+ ls race.178261
+ echo 'Race(s) detected'
Race(s) detected
+ exit 1
##[error]Process completed with exit code 1.Suggested fix: Use synchronization mechanisms like mutexes or channels to ensure that shared variables are accessed in a thread-safe manner. 2. Connection refused:[go_core_tests_integration]Source of Error:Get "http://localhost:22007/health?failing": dial tcp [::1]:22007: connect: connection refusedSuggested fix: Ensure that the service is running and accessible on the specified port before running the tests. 3. Invalid address:[go_core_ccip_deployment_tests]Source of Error:Txm: Broadcaster failed to start: Broadcaster: failed to load EnabledAddresses: invalid address: EthKeyV2{PrivateKey: <redacted>, Address: 0x7bcaC1b23670ACAbc6359e175bd76b398b7F402d}Suggested fix: Verify that the Ethereum address is correctly formatted and valid. Ensure that the address is correctly loaded and passed to the Broadcaster. 4. Comment formatting:[lint]Source of Error:core/cmd/shell.go:215:2: commentFormatting: put a space between `//` and comment text (gocritic)
//TODO now this is done twice on this path....
^Suggested fix: Add a space after 5. File not properly formatted:[lint]Source of Error:core/services/llo/mercurytransmitter/transmitter.go:129:1: File is not properly formatted (goimports)
Lggr logger.Logger
^Suggested fix: Run 6. Pipeline not complete:[go_core_tests]Source of Error:delegate_test.go:155: pipeline not completeSuggested fix: Investigate why the pipeline is not completing and ensure that all necessary steps are executed and completed within the test. 7. Index out of range:[go_core_tests]Source of Error:panic: runtime error: index out of range [0] with length 0 [recovered]
panic: runtime error: index out of range [0] with length 0Suggested fix: Add checks to ensure that the index is within the valid range before accessing the slice or array. 8. Unexpected command failure:[go_core_tests_integration]Source of Error:FAIL: testdata/scripts/health/multi-chain-loopp.txtar:20: unexpected command failureSuggested fix: Review the command and its dependencies to ensure it can execute successfully. Check for any missing configurations or prerequisites. 9. Mock method call exceeded:[go_core_tests]Source of Error:mock.go:351:
assert: mock: The method has been called over 1 times.
Either do one more Mock.On("MarkConsumed").Return(...), or remove extra call.Suggested fix: Adjust the mock expectations to match the actual number of calls or review the code to ensure the method is not called excessively. 10. Test expectation not met:[go_core_tests]Source of Error:tracker.go:425: FAIL: LatestAndFinalizedBlock(string)
at: [/home/runner/work/chainlink/chainlink/core/services/relay/evm/write_target_test.go:124]Suggested fix: Ensure that the test setup and execution align with the expected number of calls. Adjust the test or the code to meet the expectations. AER Report: Operator UI CI ran successfully ✅ |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌73 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
jmank88
force-pushed
the
CRE-305-agnostic-keystore
branch
3 times, most recently
from
0b6ec89 to
901426b
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌88 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
jmank88
force-pushed
the
CRE-305-agnostic-keystore
branch
from
901426b to
75b79ee
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
jmank88
force-pushed
the
CRE-305-agnostic-keystore
branch
2 times, most recently
from
b962bb0 to
7c417a3
Compare
jmank88
force-pushed
the
CRE-305-agnostic-keystore
branch
from
7c417a3 to
6ab5b2f
Compare
|
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌5 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs-e969227e-4cde-4ba4-8cb0-8e13e99fc1ad.json. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smartcontract-it.atlassian.net/browse/CRE-305
This PR set swaps out many direct uses of private keys for signing function calls that can be wired over grpc between plugins. This is necessary for LOOPification and simplifies EVM extraction.
Requires:
Supports: