Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix/tile menu images templated #204

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Fix/tile menu images templated #204

merged 3 commits into from
Oct 16, 2019

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Oct 9, 2019 •
edited
Loading

This PR is depends on changes made in #202

This PR fixes #197

This PR adds the isTemplate and fill property to the <Image/> object created within an HScrollMenu-Item.

Updates:

  • Remove unnecessary parameters being passed from HScrollMenu to HScrollMenu-Item
  • Add isTemplate and fill property to <Image/> in HScrollMenu-Item
  • Update references that were to previously unnecessary, now removed props in HScrollMenu-Item

@iCollin iCollin merged commit a569939 into develop Oct 16, 2019
@iCollin iCollin deleted the fix/tile_menu_images_templated branch October 16, 2019 18:22
@iCollin iCollin mentioned this pull request Oct 16, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jacobkeeler jacobkeeler jacobkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iCollin @jacobkeeler