[SDL 0109] SetAudioStreamingIndicator RPC #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
theresalech
requested changes
Sep 24, 2018
There was a problem hiding this comment.
@kshala-ford I've left a couple of comments. Can you please review and address accordingly? Let me know of any questions. Thanks!
MOBILE_API.xml
Outdated
| Default playback indicator. | ||
| By default the playback indicator should be PLAY_PAUSE when: | ||
| - the media app is newly registered on the head unit (after RegisterAppInterface) | ||
| - the media app was closed by the user (App enteres HMI_NONE) |
There was a problem hiding this comment.
This should say "enters `HMI_NONE" (removing extra "e" and adding code blocks around "HMI_NONE")
theresalech
requested changes
Sep 28, 2018
jacobkeeler
force-pushed
the
feature/audio_streaming_indicator
branch
from
1b4abbb
to
3e9a1a4
Compare
theresalech
approved these changes
Sep 28, 2018
joeygrover
approved these changes
Oct 2, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #67 according to the SDL proposal 0109
This PR is ready for review.
Risk
This PR makes minor API changes.,
CLA