Add basic README for RPC parser #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShobhitAd
requested changes
Sep 28, 2021
| The markdown generator requires the use the interface parser included in this project, which has its own set of dependencies. These dependency libraries are described in the interface parser's `requirements.txt` and should be pre-installed by the following command: | ||
|
|
||
| ```bash | ||
| pip3 install -r ../InterfaceParser/requirements.txt |
There was a problem hiding this comment.
One minor suggestion. pip may not be installed by default on the system so we might want to include a pip installation step (like we did for the HMIs https://github.com/smartdevicelink/generic_hmi#dependencies)
Suggested change
| pip3 install -r ../InterfaceParser/requirements.txt | |
| sudo apt install python3 python3-pip -y | |
| pip3 install -r ../InterfaceParser/requirements.txt |
ShobhitAd
approved these changes
Sep 29, 2021
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic README file to describe the usage of the markdown generator script in the
RpcParsersubdirectory.