PolicyTableUpdate must be triggered in case no "certificate" exist at "module_config" section of PolicyTable #1783
Conversation
dboltovskyi
requested review from
aderiabin,
GetmanetsIrina,
AByzhynar and
LitvinenkoIra
dboltovskyi
force-pushed
the
feature/ptu_certificate
branch
from
7fc9187 to
34ee062
Compare
| runner.SetParameters({ isSelfIncluded = false }) | ||
| runner.Title("Preconditions") | ||
| runner.Step("Clean environment", common.preconditions) | ||
| runner.Step("Set ForceProtectedService OFF", common.setForceProtectedServiceParam, { "0x0A" }) |
There was a problem hiding this comment.
Set ForceProtectedService ON
There was a problem hiding this comment.
@GetmanetsIrina Done in 7c037eb
| runner.SetParameters({ isSelfIncluded = false }) | ||
| runner.Title("Preconditions") | ||
| runner.Step("Clean environment", common.preconditions) | ||
| runner.Step("Set ForceProtectedService OFF", common.setForceProtectedServiceParam, { "0x0B" }) |
There was a problem hiding this comment.
Set ForceProtectedService ON
There was a problem hiding this comment.
@GetmanetsIrina Done in 7c037eb
| end | ||
|
|
||
| local function expNotificationFunc() | ||
| common.getHMIConnection():ExpectNotification("SDL.OnStatusUpdate", |
There was a problem hiding this comment.
Expectation is not triggered during script execution.
There was a problem hiding this comment.
@GetmanetsIrina Already fixed in last commit ea0f87c
|
|
||
| runner.Title("Test") | ||
| runner.Step("Register App", common.registerApp) | ||
| runner.Step("PolicyTableUpdate fails", common.policyTableUpdate, { ptUpdate, expNotificationFunc }) |
There was a problem hiding this comment.
PolicyTableUpdate fails -> test case is provided successful PolicyTableUpdate
There was a problem hiding this comment.
@GetmanetsIrina Fixed in ea0f87c
| config.application2.registerAppInterfaceParams.appHMIType = { appHMIType[2] } | ||
|
|
||
| --[[ Local Functions ]] | ||
| local function ptUpdate(pTbl) |
There was a problem hiding this comment.
Please add pTbl.policy_table.module_config.certificate = nil in ptUpdate to make sure that certificate is absent.
There was a problem hiding this comment.
@GetmanetsIrina Already added in commit ea0f87c
| return self.mobile_session_impl:ExpectControlMessage(pServiceId, pData) | ||
| end | ||
| function pMobSession.mobile_session_impl.control_services:ExpectHandshakeMessage() | ||
| -- if not self.session.isSecuredSession then |
There was a problem hiding this comment.
Remove commented code in function.
There was a problem hiding this comment.
@GetmanetsIrina Done in ea0f87c
| self.mobile_session_impl.control_services:ExpectHandshakeMessage(service) | ||
| :Do(function(e) | ||
| local isHandshakeFinished = self.mobile_session_impl.control_services.session.security:isHandshakeFinished() | ||
| -- print(e.occurences, isHandshakeFinished) |
There was a problem hiding this comment.
Remove commented code
There was a problem hiding this comment.
@GetmanetsIrina Done in ea0f87c
| common.getMobileSession():ExpectHandshakeMessage() | ||
| :Times(handshakeOccurences) | ||
|
|
||
| common.delayedExp() |
There was a problem hiding this comment.
@dboltovskyi I would propose to set delay time explicitly
There was a problem hiding this comment.
@aderiabin If the value of timeout is not defined default one (2000 ms) is used
user_modules/script_runner.lua
Outdated
| @@ -5,9 +5,11 @@ local commonFunctions = require('user_modules/shared_testcases/commonFunctions') | |||
|
|
|||
| local isInitialStep = true | |||
| local isPrintTitle = false | |||
| local isSelfIncluded = true | |||
There was a problem hiding this comment.
@dboltovskyi I would propose to add isSelfIncluded flag into runner.testSettings table instead, because the flag is a part of settings of current test, not runner.
Also function runner.SetParameters is redundant if use runner.testSettings
There was a problem hiding this comment.
@aderiabin Accepted. Done in commit 391ab59
dboltovskyi
force-pushed
the
feature/ptu_certificate
branch
from
47a0b02 to
29a323c
Compare
This PR implements test scripts for the following issues:
In order to run scripts specific version of ATF from PR #107 has to be used
Fix for SDL Core is in PR #1971