-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Scripts to check DTLS and certificate processing fixes for SSL handshake flow #1918
Merged
Jack-Byrne
merged 11 commits into
develop
from
fix/fix_ssl_handshake_flow_integration_branch
Jun 19, 2018
Merged
Scripts to check DTLS and certificate processing fixes for SSL handshake flow #1918
Jack-Byrne
merged 11 commits into
develop
from
fix/fix_ssl_handshake_flow_integration_branch
Jun 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrapitis
approved these changes
Jun 5, 2018
@theresalech this PR is ready for review. |
@mrapitis does this correspond to a feature planned for the Core 5.0 Release? Can you please provide a link to the issue? |
@theresalech Yes, the issues mentioned in the original PR are linked to the DTLS and GetSystemTime features linked below: |
39f023d
to
3989b11
Compare
Refactoring
3989b11
to
f95449c
Compare
Jack-Byrne
approved these changes
Jun 19, 2018
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATF Test Scripts to check issues:
This PR is ready for review.
Summary
This pull request includes scripts to check mentioned issues.
It also incorporates scripts from #1856 and #1864 pull requests.
All scripts are combined in
./test_sets/security.txt
test set (except the one mentioned in dependencies)ATF version
https://github.com/smartdevicelink/sdl_atf/tree/feature/security
Changelog
Enhancements
actions
moduleactions
module:setPTUTable()
setHMIAppId()
hmiConnection:RaiseEvent()
hmiConnection:ExpectEvent()
mobileConnection:RaiseEvent()
mobileConnection:ExpectEvent()
utils
module:isFileExist()
Dependencies:
Currently only one script in this pull request depends on BSON library: ./test_scripts/Security/SSLHandshakeFlow/018_V5_happy_path_SUCCESS.lua
Such implementation of BSON support will be done in separate pull request
CLA