Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Scripts to check DTLS and certificate processing fixes for SSL handshake flow #1918

Merged
merged 11 commits into from
Jun 19, 2018

Conversation

dboltovskyi
Copy link
Contributor

@dboltovskyi dboltovskyi commented Jun 5, 2018

ATF Test Scripts to check issues:

This PR is ready for review.

Summary

This pull request includes scripts to check mentioned issues.
It also incorporates scripts from #1856 and #1864 pull requests.

All scripts are combined in ./test_sets/security.txt test set (except the one mentioned in dependencies)

ATF version

https://github.com/smartdevicelink/sdl_atf/tree/feature/security

Changelog

Enhancements
  • Refactoring of actions module
  • Introducing of a new functions in actions module:
    • setPTUTable()
    • setHMIAppId()
    • hmiConnection:RaiseEvent()
    • hmiConnection:ExpectEvent()
    • mobileConnection:RaiseEvent()
    • mobileConnection:ExpectEvent()
  • Introducing of a new functions in utils module:
    • isFileExist()

Dependencies:

  • Implementation of BSON support in ATF.
    Currently only one script in this pull request depends on BSON library: ./test_scripts/Security/SSLHandshakeFlow/018_V5_happy_path_SUCCESS.lua
    Such implementation of BSON support will be done in separate pull request

CLA

@dboltovskyi dboltovskyi requested a review from mrapitis June 5, 2018 15:04
@dboltovskyi dboltovskyi changed the title Fix/fix ssl handshake flow integration branch Test scripts to check integration branch with fixes for SSL handshake flow Jun 5, 2018
@dboltovskyi dboltovskyi changed the title Test scripts to check integration branch with fixes for SSL handshake flow Scripts to check integration branch with fixes for SSL handshake flow Jun 5, 2018
@mrapitis
Copy link

mrapitis commented Jun 5, 2018

@theresalech this PR is ready for review.

@theresalech
Copy link
Contributor

@mrapitis does this correspond to a feature planned for the Core 5.0 Release? Can you please provide a link to the issue?

@mrapitis
Copy link

mrapitis commented Jun 5, 2018

@theresalech Yes, the issues mentioned in the original PR are linked to the DTLS and GetSystemTime features linked below:
smartdevicelink/sdl_core#1479
smartdevicelink/sdl_core#1963

@dboltovskyi dboltovskyi force-pushed the fix/fix_ssl_handshake_flow_integration_branch branch from 39f023d to 3989b11 Compare June 15, 2018 07:27
@dboltovskyi dboltovskyi changed the title Scripts to check integration branch with fixes for SSL handshake flow Scripts to check DTLS and certificate processing fixes for SSL handshake flow Jun 19, 2018
@dboltovskyi dboltovskyi force-pushed the fix/fix_ssl_handshake_flow_integration_branch branch from 3989b11 to f95449c Compare June 19, 2018 13:33
@Jack-Byrne Jack-Byrne merged commit 229c1ed into develop Jun 19, 2018
@jacobkeeler jacobkeeler deleted the fix/fix_ssl_handshake_flow_integration_branch branch May 28, 2019 20:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants