Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Scripts for feature "SDL behavior in case of LOW_VOLTAGE event" #1953

Merged
merged 6 commits into from
Aug 21, 2018

Conversation

GetmanetsIrina
Copy link
Contributor

@GetmanetsIrina GetmanetsIrina commented Jun 27, 2018

ATF Test Scripts to check TBD
This PR is ready for review.

Summary

Script for feature "SDL behavior in case of LOW_VOLTAGE event".
Tests #2233

ATF version

Develop branch

CLA

@dboltovskyi dboltovskyi force-pushed the feature/low_voltage branch 3 times, most recently from 5bc9206 to 19f52dd Compare July 25, 2018 08:18
-- 3) All apps have some data that can be resumed
-- 4) SDL get LOW_VOLTAGE signal
-- 5) And then SDL get WAKE_UP signal
-- 6) All apps are registered with the same hashID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does All apps are registered with the same hashID mean there is only one hashid and all the apps use the same id? probably not.
I think each app shall have its own hashid, when apps get disconnected and reconnect, each app uses the same id of their own

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yang1070 Correct, each application has it's own hashId

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for clarification, reword to All apps are registered with their corresponding hashIDs

-- 4) SDL get LOW_VOLTAGE signal
-- 5) And then SDL get IGNITION_OFF signal
-- 6) And then SDL is started
-- 7) All apps are registered with the same hashID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question regarding All apps are registered with the same hashID

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yang1070 Please see above

-- 2. App has some persistent data that can be resumed
-- 2. Mobile app is disconnected during the time frame of 30 sec (inclusive) before "SDL_LOW_VOLTAGE" unix signal from HMI
-- 3. Mobile app registers with the same hashID during 30 sec. after "WAKE_UP" unix signal in the same ignition cycle
-- 4. there is application currently in LIMITED

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with mobile projection, there can be multiple apps in LIMITED

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yang1070 This was an original requirement for resumption functionality that is transferred to Low Voltage

-- 2. App has some persistent data that can be resumed
-- 3. Mobile app is disconnected during the time frame of 30 sec (inclusive) before "SDL_LOW_VOLTAGE" unix signal from HMI
-- 4. "IGNITION_OFF" unix signal from HMI
-- 5. IGNITION_ON is performed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is IGNITION_ON

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yang1070 IGNITION_ONmeans new Ignition cycle is started

Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yang1070
Copy link

@theresalech Ford has reviewed, tested and approved this PR. It is ready for Livio to review.

@theresalech theresalech requested a review from jacobkeeler July 30, 2018 19:11
-- 3) All apps have some data that can be resumed
-- 4) SDL get LOW_VOLTAGE signal
-- 5) And then SDL get WAKE_UP signal
-- 6) All apps are registered with the same hashID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for clarification, reword to All apps are registered with their corresponding hashIDs

-- 4) And then SDL get WAKE_UP signal
-- SDL does:
-- 1) Resume it’s work successfully (as for Resumption)
-- 2) Discard processing of RPC
Copy link
Contributor

@jacobkeeler jacobkeeler Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this description, you should check that if the HMI sends a response to UI.Show after WAKE_UP, that it is ignored and a response is not sent to the mobile app.

end

local function checkResumptionHMILevel()
common.getMobileSession(1):ExpectNotification("OnHMIStatus",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decrease indent

@GetmanetsIrina
Copy link
Contributor Author

@jacobkeeler , please find update in 820e2ff .

common.getMobileSession():ExpectAny():Times(0)
common.getHMIConnection():ExpectAny():Times(0)
common.sendIgnitionOffSignal()
common.wait(2000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails on this step, but no information is provided, it might be just considering the shutdown of Core to be a failure.

Copy link
Contributor

@dboltovskyi dboltovskyi Aug 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobkeeler Could you check please that you use latest version of ATF (smartdevicelink/sdl_atf@900f936)
A fix was implemented in ATF a couple of weeks ago to handle this case in script.

@jacobkeeler jacobkeeler merged commit edb0223 into develop Aug 21, 2018
@jacobkeeler jacobkeeler deleted the feature/low_voltage branch May 28, 2019 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants