Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Scripts for 'Updating DOP value range for GPS notification' feature #1987

Merged
merged 5 commits into from
Aug 14, 2018

Conversation

dboltovskyi
Copy link
Contributor

@dboltovskyi dboltovskyi force-pushed the feature/updating_dop_value_range branch from 2f36a8d to c8a5fca Compare July 25, 2018 12:49
Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yang1070
Copy link

@theresalech Ford has reviewed, tested and approved this change. It is ready for Livio to review.

@theresalech theresalech requested a review from conlain-k July 31, 2018 20:15
@conlain-k
Copy link
Contributor

Does the usage of inbound/outbound in the test naming mean "in/outside of the allowed bounds"?
Looking at the first two tests descriptions (and names):

-- 3. And HMI responds with gps data with one of the following parameters set to inbound max value (1000):
-- 3. And HMI responds with gps data with one of the following parameters set to outbound max value (1001):

This language seems a little confusing to me, I would propose using something like

-- 3. And HMI responds with gps data with one of the following parameters set to exactly max value (1000):
-- 3. And HMI responds with gps data with one of the following parameters set to beyond max value (1000):

inbound/outbound seems to imply directionality -- at first I thought it meant where an RPC was going. in bounds and out of bounds would also be good alternatives.

Otherwise these tests look good to me, they all pass on Ubuntu 18.04 as well.

@dboltovskyi
Copy link
Contributor Author

@conlain-k
Thank you for your remarks.
Please find updated descriptions in 45ea7ab (a few test scripts were renamed accordingly)

@jacobkeeler jacobkeeler force-pushed the feature/updating_dop_value_range branch from 9f079b6 to 6c926dd Compare August 14, 2018 20:02
@jacobkeeler jacobkeeler merged commit c103b78 into develop Aug 14, 2018
@jacobkeeler jacobkeeler deleted the feature/updating_dop_value_range branch May 28, 2019 20:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants