Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add tests for using new menuLayout parameter #2213

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Jul 24, 2019

ATF Test Scripts to check #2925

This PR is ready for review.

Summary

Add the ability to request a tiled menu through SetGlobalProperties or AddSubMenu RPCs.

ATF version

develop

Changelog

Enhancements
  • Adds new parameter menuLayout to SetGlobalProperties RPC.
  • Adds new parameter menuLayout to AddSubMenu RPC.
  • Adds new parameter menuLayoutsAvailable to HMI Capabilities

CLA

@@ -0,0 +1,79 @@
---------------------------------------------------------------------------------------------------
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in the name "unspported"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 9ff4d86

@Jack-Byrne
Copy link
Collaborator

Please put request and response parameter objects under the section

--[[ Local Variables ]]

And move the functions to a section names

--[[ Local Functions ]]

Example test script format

@theresalech
Copy link
Contributor

Please ensure implementation reflects the revisions included in accepted Evolution Proposal SDL 0231 Revisions - Add Tiles as an Option for Main Menus. This is a revision to remove the default value (defvalue="LIST") from the menuLayout parameter introduced by the original proposal. Please reference issue and proposal markdown file for more details.

@iCollin iCollin merged commit a2e18e2 into develop Aug 15, 2019
@iCollin iCollin deleted the feature/menu_tiles branch August 15, 2019 14:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants