Add script to verify 1885 issue #2303
Conversation
| -- SDL must cut off <unknown_parameter> or <unknown_RPC> continue validating received PTU without <unknown_parameter> or | ||
| -- <unknown_RPC> merge valid Updated PT without <unknown_parameter> or <unknown_RPC> with LocalPT in case | ||
| -- of no other failures | ||
| -- Actual result:N/A |
There was a problem hiding this comment.
Actual result is redundant for script
There was a problem hiding this comment.
@GetmanetsIrina You can find the updates in the commit 93cd00c
| runner.testSettings.isSelfIncluded = false | ||
|
|
||
| --[[ Local variables ]] | ||
| -- set default parameters for 'SendLocation' RPC |
There was a problem hiding this comment.
Why we need params for Sendlocation?
There was a problem hiding this comment.
@GetmanetsIrina , These params are necessary for successful SendLocation RPC processing after PTU with unknown RPC
|
|
||
| runner.Title("Test") | ||
| runner.Step("PTU update with unknown API", common.policyTableUpdate, { ptuUpdateFuncRPC }) | ||
| runner.Step("Check applying of PT by processing SendLocation", SuccessfulProcessingRPC, |
There was a problem hiding this comment.
Why SendLocation RPC should be processed in case this RPC is not present in permissions update?
There was a problem hiding this comment.
@GetmanetsIrina, To verify that SDL cut off unknown RPC from PTU and that SendLocation RPC can be processed after PTU if it is present in permissions update
| local function SuccessfulProcessingRPC(RPC, params, interface) | ||
| local cid = common.getMobileSession():SendRPC(RPC, params) | ||
| common.getHMIConnection():ExpectRequest(interface .. "." .. RPC, params) | ||
| -- :Do(function(_,data) |
There was a problem hiding this comment.
Please remove commented code
There was a problem hiding this comment.
@GetmanetsIrina You can find the updates in the commit 93cd00c
| if RPC == "GetVehicleData" then | ||
| common.getHMIConnection():SendResponse(data.id, data.method, "SUCCESS", {gps = gpsResponse}) | ||
| elseif | ||
| RPC == "SubscribeVehicleData" then |
There was a problem hiding this comment.
why do we need this code here? There is no successful processing of SubscribeVehicleData
There was a problem hiding this comment.
@GetmanetsIrina You can find the updates in the commit d3bc0cd
| --! self - test object | ||
| --! @return: none | ||
| --]] | ||
| local function DisallowedRPC(RPC, params, interface) |
There was a problem hiding this comment.
This function is used for only one RPC, so can be specified only for SubscribeVehicleData
There was a problem hiding this comment.
@GetmanetsIrina You can find the updates in the commit 93cd00c
| --! RPC - RPC name | ||
| --! params - RPC params for mobile request | ||
| --! interface - interface of RPC on HMI | ||
| --! self - test object |
There was a problem hiding this comment.
Do we have self here?
There was a problem hiding this comment.
@GetmanetsIrina You can find the updates in the commit 93cd00c. self was deleted
| --! RPC - RPC name | ||
| --! params - RPC params for mobile request | ||
| --! interface - interface of RPC on HMI | ||
| --! self - test object |
There was a problem hiding this comment.
Do we have self here?
There was a problem hiding this comment.
@GetmanetsIrina You can find the updates in the commit 93cd00c
| runner.Step("Check applying of PT by processing GetVehicleData", SuccessfulProcessingRPC, | ||
| { "GetVehicleData", { gps = true }, "VehicleInfo" }) | ||
| runner.Step("Check applying of PT by processing SubscribeVehicleData", DisallowedRPC, | ||
| { "SubscribeVehicleData", { gps = true }, "VehicleInfo" }) |
There was a problem hiding this comment.
What about checks for items ( unknown RPC and parameter ) in LPT or snapshot?
There was a problem hiding this comment.
@GetmanetsIrina You can find the updates in the commit 93cd00c
|
The internal review iteration has been moved to the LuxoftSDL. |
ATF Test Scripts to check #1885
This PR is ready for review.
Summary
A test script has been added to verify that the problem has been fixed.
ATF version
develop
CLA